Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yafc doesn't calculate energy storage for variable-output electric energy interfaces #228

Open
2 tasks
DaleStan opened this issue Aug 8, 2024 · 4 comments
Open
2 tasks

Comments

@DaleStan
Copy link
Collaborator

DaleStan commented Aug 8, 2024

Related to #226, power sources such as pY's fish turbines and Nullius's wind turbines have script-controlled variable output. They need some some sort of energy storage, significantly more generators than the average output would suggest, or both.

Yafc can't calculate the energy storage needs because the mods don't share the necessary information, so:

  • Determine the extra information needed and add it to either the mods themselves or the Mod-fixes folder.
  • Use this information to calculate how many accumulators are needed, the same way solar panels work now.
shpaass added a commit that referenced this issue Aug 9, 2024
This fixes #226 and ShadowTheAge#205.

There are still improvements possible; see #228 for more, but I think
that's a separate issue.
@veger
Copy link
Collaborator

veger commented Sep 6, 2024

I guess this can be closed by #229? (At least the PR suggest so)

@shpaass
Copy link
Owner

shpaass commented Sep 6, 2024

I guess this can be closed by #229? (At least the PR suggest so)

The PR #229 says the following:

There are still improvements possible; see #228 for more, but I think that's a separate issue.

In other words, this issue was not resolved by #229.

@veger
Copy link
Collaborator

veger commented Sep 6, 2024

Oh I misread it states that it implements issue 226 and not 228 😞
Sorry for the noise.

@shpaass
Copy link
Owner

shpaass commented Sep 6, 2024

You're doing fine. You've already checked multiple issues and closed the ones that needed to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants