Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to scroll past the bottom recipe #14

Closed
shpaass opened this issue Feb 4, 2024 · 3 comments · Fixed by #50
Closed

Make it possible to scroll past the bottom recipe #14

shpaass opened this issue Feb 4, 2024 · 3 comments · Fixed by #50

Comments

@shpaass
Copy link
Owner

shpaass commented Feb 4, 2024

In long chains of recipes, the bottom recipe is near the bottom edge of the app, which is uncomfortable.
It would be good to scroll past the bottom recipe, so the lowest chosen recipe is in the middle of the app instead of its bottom edge
@shpaass
Copy link
Owner Author

shpaass commented Feb 20, 2024

This becomes a hurdle instead of an inconvenience when the horizontal bar appears and hides the numbers of the bottom row.
image

@shpaass shpaass removed the backlog label Feb 21, 2024
shihan42 added a commit to shihan42/yafc-ce that referenced this issue Feb 21, 2024
@shihan42
Project pages (e.g. production tables, production summaries) get 50% …
1259fd9 
…bottom padding to enable scrolling past the last row

The base class Scrollable is used in different places (e.g. project pages, item explorer). To ensure that only those subclasses that need vertical bottom padding the padding factor has a default value of 0%. Project pages switch that to 50% to enable scrolling past the last row.

Closes shpaass#14
@shihan42 shihan42 mentioned this issue Feb 21, 2024
Merged
@shpaass
Copy link
Owner Author

shpaass commented Feb 21, 2024

After the counterexample of half an empty screen, I think that a couple rows of the empty space is sufficient.

@veger
Copy link
Collaborator

veger commented Feb 21, 2024

This becomes a hurdle instead of an inconvenience when the horizontal bar appears and hides the numbers of the bottom row.

Proper fix for this is to add a bit of padding when the horizontal scrollbar is activated.

shihan42 added a commit to shihan42/yafc-ce that referenced this issue Feb 22, 2024
@shihan42
Project pages (e.g. production tables, production summaries) get 50% …
327cbbc 
…bottom padding to enable scrolling past the last row

The base class Scrollable is used in different places (e.g. project pages, item explorer). To ensure that only those subclasses that need vertical bottom padding the padding factor has a default value of 0%. Project pages switch that to 50% to enable scrolling past the last row.

Closes shpaass#14
shihan42 added a commit to shihan42/yafc-ce that referenced this issue Feb 22, 2024
@shihan42
Project pages (e.g. production tables, production summaries) get 50% …
ff28415 
…bottom padding to enable scrolling past the last row

The base class Scrollable is used in different places (e.g. project pages, item explorer). To ensure that only those subclasses that need vertical bottom padding the padding factor has a default value of 0%. Project pages switch that to 50% to enable scrolling past the last row.

Closes shpaass#14
shihan42 added a commit that referenced this issue Feb 22, 2024
@shihan42
Project pages get bottom padding (#50)
e524df7 
Project pages (e.g. production tables, production summaries) get a bottom padding of 100 pixels to enable scrolling past the last row.

The base class Scrollable is used in different places (e.g. project pages, item explorer). To ensure that only those subclasses that need vertical bottom padding the default value for useBottomPadding is false. Project pages enable scrolling past the last row.

Closes #14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Project pages get 50% bottom padding shihan42/yafc-ce
2 participants
@veger @shpaass