ApiVersions rewrite #1833
Merged
ApiVersions rewrite #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
api_versions_rewrite_without_test
branch
from
a34c269 to
cda8015
Compare
CodSpeed Performance ReportMerging #1833 will not alter performanceComparing Summary
|
ronycsdu
approved these changes
Nov 22, 2024
justinweng-instaclustr
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to #1832 for reasoning behind this PR.
This PR lacks the unit test added in #1832 since that is blocked on upstream. Since the unit test is used to verify how up to date shotover is instead of correctness, it is reasonable to land this without the unit test.