KafkaSinkSingle: remove dest host config, rely solely on dest port #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
kafka_sink_single_remove_host_config
branch
from
f47bc89 to
1082b2c
Compare
rukai
force-pushed
the
kafka_sink_single_remove_host_config
branch
3 times, most recently
from
5ade993 to
7a04ba4
Compare
rukai
force-pushed
the
kafka_sink_single_remove_host_config
branch
from
7a04ba4 to
d3dd1b6
Compare
conorbros
approved these changes
Nov 27, 2023
cjrolo
reviewed
Nov 27, 2023
cjrolo
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the comment I added:
KafkaSinkSingle is designed solely for the use case of running a shotover instance on the same machine as each kafka instance.
I cannot think of a valid configuration where the destination host is set to a value other than the private ip of the machine.
It could technically be set to
localhostbut AFAIK that doesnt offer any advantages over just using the private ip.Is there a case i'm missing?
So given this, allowing the user to set the full address is just a footgun so we should remove this config instead only allowing the user to set the port.