Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dockerfile changes #1364

Merged
merged 1 commit into from
Nov 2, 2023
Merged

dockerfile changes #1364

merged 1 commit into from
Nov 2, 2023

Conversation

conorbros
Copy link
Member

@conorbros conorbros requested a review from rukai November 1, 2023 01:21
rukai
rukai reviewed Nov 1, 2023
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@rukai
Copy link
Member

rukai commented Nov 2, 2023 •
edited
Loading

I tried building this via docker build -t shotover-foo . and got:

  Compiling time-macros v0.2.15
   Compiling vsimd v0.8.0
error: linking with `cc` failed: exit status: 1
  |
  = note: LC_ALL="C" PATH="/usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/bin:/usr/local/cargo/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" VSLANG="1033" "cc" "-m64" "/tmp/rustcOgmrgb/symbols.o" "/shotover-proxy/target/release/build/futures-task-2b7e1c96b03b2edb/build_script_build-2b7e1c96b03b2edb.build_script_build.9ee364472285498e-cgu.0.rcgu.o" "/shotover-proxy/target/release/build/futures-task-2b7e1c96b03b2edb/build_script_build-2b7e1c96b03b2edb.472yuryc000t1equ.rcgu.o" "-Wl,--as-needed" "-L" "/shotover-proxy/target/release/deps" "-L" "/usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-Wl,-Bstatic" "/usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-6498d8891e016dca.rlib" "/usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libpanic_unwind-3debdee1a9058d84.rlib" "/usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libobject-8339c5bd5cbc92bf.rlib" "/usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libmemchr-160ebcebb54c11ba.rlib" "/usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libaddr2line-95c75789f1b65e37.rlib" "/usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libgimli-7e8094f2d6258832.rlib" "/usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/librustc_demangle-bac9783ef1b45db0.rlib" "/usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd_detect-a1cd87df2f2d8e76.rlib" "/usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libhashbrown-7fd06d468d7dba16.rlib" "/usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/librustc_std_workspace_alloc-5ac19487656e05bf.rlib" "/usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libminiz_oxide-c7c35d32cf825c11.rlib" "/usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libadler-c523f1571362e70b.rlib" "/usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libunwind-85f17c92b770a911.rlib" "/usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcfg_if-598d3ba148dadcea.rlib" "/usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liblibc-a58ec2dab545caa4.rlib" "/usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc-f9dda8cca149f0fc.rlib" "/usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/librustc_std_workspace_core-7ba4c315dd7a3503.rlib" "/usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcore-5ac2993e19124966.rlib" "/usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-df2fb7f50dec519a.rlib" "-Wl,-Bdynamic" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-L" "/usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-o" "/shotover-proxy/target/release/build/futures-task-2b7e1c96b03b2edb/build_script_build-2b7e1c96b03b2edb" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-nodefaultlibs"
  = note: /usr/bin/ld: /usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libgimli-7e8094f2d6258832.rlib(gimli-7e8094f2d6258832.gimli.ec6d3472a17f7c41-cgu.0.rcgu.o): Relocations in generic ELF (EM: 62)
          /usr/bin/ld: /usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libgimli-7e8094f2d6258832.rlib(gimli-7e8094f2d6258832.gimli.ec6d3472a17f7c41-cgu.0.rcgu.o): Relocations in generic ELF (EM: 62)
          /usr/bin/ld: /usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libgimli-7e8094f2d6258832.rlib(gimli-7e8094f2d6258832.gimli.ec6d3472a17f7c41-cgu.0.rcgu.o): Relocations in generic ELF (EM: 62)
          /usr/bin/ld: /usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libgimli-7e8094f2d6258832.rlib(gimli-7e8094f2d6258832.gimli.ec6d3472a17f7c41-cgu.0.rcgu.o): Relocations in generic ELF (EM: 62)
          /usr/bin/ld: /usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libgimli-7e8094f2d6258832.rlib(gimli-7e8094f2d6258832.gimli.ec6d3472a17f7c41-cgu.0.rcgu.o): Relocations in generic ELF (EM: 62)
          /usr/bin/ld: /usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libgimli-7e8094f2d6258832.rlib(gimli-7e8094f2d6258832.gimli.ec6d3472a17f7c41-cgu.0.rcgu.o): Relocations in generic ELF (EM: 62)
          /usr/bin/ld: /usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libgimli-7e8094f2d6258832.rlib(gimli-7e8094f2d6258832.gimli.ec6d3472a17f7c41-cgu.0.rcgu.o): Relocations in generic ELF (EM: 62)
          /usr/bin/ld: /usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libgimli-7e8094f2d6258832.rlib(gimli-7e8094f2d6258832.gimli.ec6d3472a17f7c41-cgu.0.rcgu.o): Relocations in generic ELF (EM: 62)
          /usr/bin/ld: /usr/local/rustup/toolchains/1.73-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libgimli-7e8094f2d6258832.rlib(gimli-7e8094f2d6258832.gimli.ec6d3472a17f7c41-cgu.0.rcgu.o): Relocations in generic ELF (EM: 62)
: error adding symbols: file in wrong format
          collect2: error: ld returned 1 exit status
          

error: could not compile `futures-task` (build script) due to previous error
warning: build failed, waiting for other jobs to finish...

But then running the command a second time succeeded... weird.
This is at least an improvement over before where it never succeeded, so I'll go ahead and approve.

@rukai rukai mentioned this pull request Nov 2, 2023
Merged
@rukai rukai enabled auto-merge (squash) November 2, 2023 19:33
@rukai rukai merged commit d9444b2 into shotover:main Nov 2, 2023
38 checks passed
@conorbros conorbros deleted the fix-docker branch November 3, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rukai rukai rukai approved these changes

@cjrolo cjrolo cjrolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conorbros @rukai @cjrolo