add zlib to allowed licenses #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I cant find anything that clearly says the zlib license is compatible with apache license. |
|
https://www.apache.org/legal/resolved.html#category-a
zlib is included in that list |
rukai
approved these changes
Sep 14, 2023
cjrolo
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI on #1298 is failing due to https://github.com/shotover/shotover-proxy/actions/runs/6180379036/job/16776751233?pr=1298#step:4:11
A dependency uses the zlib license which we have not allowed in our
deny.toml.Zlib is described as a permissive free software license and has been approved by the Free Software Foundation as a free software license and by the Open Source Initiative as an open source license. It is compatible with the GNU General Public License. refs
I also removed
pktparsefrom our exceptions as we no longer use it as a dependency.