Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-demo): variants displaying #1677

Merged
merged 4 commits into from
Feb 12, 2025
Merged

fix(vue-demo): variants displaying #1677

merged 4 commits into from
Feb 12, 2025

Conversation

mdanilowicz
Copy link
Collaborator

Description

This pull request addresses a bug fix and improvements related to displaying product variants on the product page in the vue-demo-store. The most important changes include fixing the display of product variants and ensuring the correct handling of option names and IDs.

Improvements to variant handling:

closes #1634

Type of change

ToDo's

Screenshots (if applicable)

Additional context

Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo ✅ Ready (Inspect) Visit Preview Feb 11, 2025 6:04pm
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Feb 11, 2025 6:04pm

Copy link

pkg-pr-new bot commented Feb 6, 2025

Open in Stackblitz

@shopware/api-client

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-client@1677

@shopware/api-gen

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-gen@1677

@shopware/cms-base-layer

npm i https://pkg.pr.new/shopware/frontends/@shopware/cms-base-layer@1677

@shopware/composables

npm i https://pkg.pr.new/shopware/frontends/@shopware/composables@1677

@shopware/helpers

npm i https://pkg.pr.new/shopware/frontends/@shopware/helpers@1677

@shopware/nuxt-module

npm i https://pkg.pr.new/shopware/frontends/@shopware/nuxt-module@1677

commit: 6219d1c

Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one fix for the changeset

it still can be attached to vue-demo-store but should also be included in nuxt layer package

@patzick patzick merged commit d663627 into main Feb 12, 2025
11 checks passed
@patzick patzick deleted the fix/GH-1634 branch February 12, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] variant configurator for non-default language selected
2 participants