-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vue-demo): variants displaying #1677
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@shopware/api-client
@shopware/api-gen
@shopware/cms-base-layer
@shopware/composables
@shopware/helpers
@shopware/nuxt-module
commit: |
patzick
reviewed
Feb 11, 2025
patzick
requested changes
Feb 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one fix for the changeset
it still can be attached to vue-demo-store
but should also be included in nuxt layer package
patzick
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses a bug fix and improvements related to displaying product variants on the product page in the
vue-demo-store
. The most important changes include fixing the display of product variants and ensuring the correct handling of option names and IDs.Improvements to variant handling:
packages/cms-base-layer/components/SwVariantConfigurator.vue
: Removed unnecessary parameters from thefindVariantForSelectedOptions
function call in theonHandleChange
method.packages/cms-base-layer/components/SwVariantConfigurator.vue
: Updated thehandleChange
method to useoptionGroup.translated.name
instead ofoptionGroup.name
andoption.translated.name
instead ofoption.name
to ensure the correct display of translated option names.closes #1634
Type of change
ToDo's
Screenshots (if applicable)
Additional context