fix(composables): add shipping costs #1580
Open
+97
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@shopware/api-client
@shopware-pwa/cms-base
@shopware-pwa/helpers-next
@shopware/api-gen
@shopware-pwa/nuxt3-module
@shopware-pwa/composables-next
commit: |
vercel
bot
temporarily deployed
to
Preview – shopware-frontends-docs
patzick
requested changes
Jan 14, 2025
| @@ -66,8 +66,14 @@ export type UseCartReturn = { | |||
| totalPrice: ComputedRef<number>; | |||
| /** | |||
| * Shipping price | |||
| * | |||
| * @deprecated Use `shippingTotal` instead | |||
There was a problem hiding this comment.
looks like this is in the wrong line? You say to use the thing which becomes deprecated ;)
.changeset/calm-ligers-give.md
Outdated
| "@shopware-pwa/composables-next": patch | ||
| --- | ||
|
|
||
| Added `shippingCosts` property in `useCart` composable that returns shipping costs of the cart, with the shipping discounts |
There was a problem hiding this comment.
no info about the deprecation
patzick
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes display shipping costs in the cart and checkout components. The changes include adding a
shippingCostsproperty to theuseCartcomposable, updating the cart and checkout components to display this information, and adding corresponding tests and translations.Feature Implementation:
packages/composables/src/useCart/useCart.ts: AddedshippingCostsproperty toUseCartReturntype and implemented the logic to compute shipping costs. [1] [2] [3]packages/composables/src/useCart/useCart.test.ts: Added tests to verify theshippingCostsproperty returns correct values.Component Updates:
templates/vue-demo-store/pages/checkout/cart.vue: Updated to useshippingCostsand display each shipping cost in the cart view. [1] [2]templates/vue-demo-store/pages/checkout/index.vue: Updated to useshippingCostsand display each shipping cost in the checkout view. [1] [2] [3]Translations:
templates/vue-demo-store/i18n/de-DE/cart.json: Added translation for "shipping costs."templates/vue-demo-store/i18n/en-GB/cart.json: Added translation for "shipping costs."templates/vue-demo-store/i18n/pl-PL/cart.json: Added translation for "shipping costs."closes #1576