-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to pass search criteria to loadNavigationElements of useNavigation #1540
feat: allow to pass search criteria to loadNavigationElements of useNavigation #1540
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
5ba549a
to
1c4a46b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
Opening params to match endpoint params is a good approach, let's just make it by extending params, not adding additional one :)
@shopware/api-client
@shopware-pwa/cms-base
@shopware-pwa/composables-next
@shopware-pwa/helpers-next
@shopware-pwa/nuxt3-module
@shopware/api-gen
commit: |
Co-authored-by: Patryk Tomczyk <13100280+patzick@users.noreply.github.com>
Thanks for the feedback @patzick! I was looking at useCategorySearch() while making these changes and probably got too inspired by this, since it also has Criteria as an additional parameter. I applied all suggested changes 👍 Is there any reason it's not done the same way as you suggested here in the readCategory operation defines both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🙌
That potentially could also be unified, I guess it was also about the default associations, but that's another case
Description
This closes the issue #1270 by allowing to pass full search criteria to the
loadNavigationElements
method ofuseNavigation
composable.Type of change
ToDo's
Screenshots (if applicable)
Additional context