fix: use shop interface instead of abstract shop class #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyim
reviewed
Oct 19, 2023
| */ | ||
| public function __construct( | ||
| private readonly string $entityClass, | ||
| private readonly ManagerRegistry $registry | ||
| ) { | ||
| if (!is_subclass_of($this->entityClass, AbstractShop::class)) { | ||
| throw new \InvalidArgumentException(sprintf('The shop entity class "%s" must extend "%s"', $this->entityClass, AbstractShop::class)); | ||
| if (!is_subclass_of($this->entityClass, ShopInterface::class)) { |
There was a problem hiding this comment.
is this really working for interfaces? not class_implements?
There was a problem hiding this comment.
https://www.php.net/manual/en/function.is-subclass-of.php
"Checks if the given object_or_class has the class class as one of its parents or implements it."
Christian-Rades
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking for AbstractShop in the Repository leaves devs no choice, but to use the abstract class.
Changed this to check for the ShopInterface instead