Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add typechecking on yarn lint (#248) #251

Merged
merged 1 commit into from
Oct 3, 2019
Merged

feat: Add typechecking on yarn lint (#248) #251

merged 1 commit into from
Oct 3, 2019

Conversation

idanyman
Copy link
Contributor

@idanyman idanyman commented Oct 3, 2019

Fixes #248

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@idanyman idanyman changed the title Add typechecking on yarn lint fix: Add typechecking on yarn lint (#248) Oct 3, 2019
@idanyman idanyman changed the title fix: Add typechecking on yarn lint (#248) feat: Add typechecking on yarn lint (#248) Oct 3, 2019
amaury1093
amaury1093 approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me. Thanks a lot @idanyman!

@amaury1093 amaury1093 merged commit 33b6ca9 into shootismoke:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaury1093 amaury1093 amaury1093 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tsc --noEmit while linting
3 participants
@idanyman @CLAassistant @amaury1093