Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support produce message to pulsar #48

Merged
merged 2 commits into from
Jan 17, 2022

Conversation

fu-turer
Copy link
Contributor

No description provided.

@fu-turer fu-turer requested review from tyluffy and shoothzj and removed request for tyluffy January 16, 2022 15:46
String topic,
String key,
String value) async {
String producerName = "flutter-dashboard-producer";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extract to PulsarConst ?

}
}

class ProducerMessage {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we define dto in module package

@@ -13,6 +13,9 @@ import 'package:paas_dashboard_flutter/vm/pulsar/pulsar_partitioned_topic_subscr
import 'package:paas_dashboard_flutter/vm/pulsar/pulsar_partitioned_topic_view_model.dart';
import 'package:provider/provider.dart';

import 'package:paas_dashboard_flutter/vm/pulsar/pulsar_partitioned_topic_produce_view_model.dart';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import order looks weird

@override
void initState() {
super.initState();
final vm = Provider.of<PulsarPartitionedTopicProduceViewModel>(context, listen: false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused var

final TopicResp topicResp;

PulsarPartitionedTopicProduceViewModel(this.pulsarInstancePo, this.tenantResp, this.namespaceResp, this.topicResp);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one space line is enough

@@ -95,6 +95,57 @@ class FormUtil {
child: Text('Create ' + resourceName));
}

static ButtonStyleButton createButton2Single(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's button single means?

pubspec.lock Outdated
@@ -219,6 +219,13 @@ packages:
url: "https://pub.dartlang.org"
source: hosted
version: "0.12.11"
material_color_utilities:
Copy link
Contributor

@lovehzj lovehzj Jan 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why add this dependency?

pubspec.lock Outdated
dependency: "direct main"
description:
name: redis
url: "https://pub.dartlang.org"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why delete this ?

@fu-turer fu-turer force-pushed the produce_msg_to_pulsar branch 2 times, most recently from 822f356 to d7c08fb Compare January 17, 2022 03:10
@goflutterjava goflutterjava merged commit 931aeae into shoothzj:main Jan 17, 2022
@shoothzj shoothzj added this to the 0.1.0 milestone Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants