-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support produce message to pulsar #48
Conversation
String topic, | ||
String key, | ||
String value) async { | ||
String producerName = "flutter-dashboard-producer"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extract to PulsarConst
?
} | ||
} | ||
|
||
class ProducerMessage { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we define dto in module package
@@ -13,6 +13,9 @@ import 'package:paas_dashboard_flutter/vm/pulsar/pulsar_partitioned_topic_subscr | |||
import 'package:paas_dashboard_flutter/vm/pulsar/pulsar_partitioned_topic_view_model.dart'; | |||
import 'package:provider/provider.dart'; | |||
|
|||
import 'package:paas_dashboard_flutter/vm/pulsar/pulsar_partitioned_topic_produce_view_model.dart'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import order looks weird
@override | ||
void initState() { | ||
super.initState(); | ||
final vm = Provider.of<PulsarPartitionedTopicProduceViewModel>(context, listen: false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused var
final TopicResp topicResp; | ||
|
||
PulsarPartitionedTopicProduceViewModel(this.pulsarInstancePo, this.tenantResp, this.namespaceResp, this.topicResp); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one space line is enough
lib/ui/util/form_util.dart
Outdated
@@ -95,6 +95,57 @@ class FormUtil { | |||
child: Text('Create ' + resourceName)); | |||
} | |||
|
|||
static ButtonStyleButton createButton2Single( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's button single means?
pubspec.lock
Outdated
@@ -219,6 +219,13 @@ packages: | |||
url: "https://pub.dartlang.org" | |||
source: hosted | |||
version: "0.12.11" | |||
material_color_utilities: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why add this dependency?
pubspec.lock
Outdated
dependency: "direct main" | ||
description: | ||
name: redis | ||
url: "https://pub.dartlang.org" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why delete this ?
822f356
to
d7c08fb
Compare
df033fd
to
097c9a7
Compare
No description provided.