Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display pulsar name policies #35

Merged
merged 1 commit into from
Jan 13, 2022
Merged

display pulsar name policies #35

merged 1 commit into from
Jan 13, 2022

Conversation

tyluffy
Copy link
Contributor

@tyluffy tyluffy commented Jan 13, 2022

@@ -52,6 +52,138 @@ class PulsarNamespaceApi {
return BacklogQuotaResp.fromJson(destinationStorageResp);
}

static Future<PolicyResp> getPolicy(String host, int port, String tenant, String namespace) async {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to put behind updateBacklogQuota, make getBacklogQuota close to updateBacklogQuota

@@ -2,6 +2,8 @@
// Generated file. Do not edit.
//

// clang-format off
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to commit

@@ -2,6 +2,8 @@
// Generated file. Do not edit.
//

// clang-format off
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to commit

@goflutterjava
Copy link
Contributor

LGTM

@goflutterjava goflutterjava merged commit b870258 into shoothzj:main Jan 13, 2022
@goflutterjava goflutterjava added this to the 0.1.0 milestone Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants