Refactor all machine #5104
Merged
Refactor all machine #5104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiuYuHui
force-pushed
the
refacter_all_machine
branch
from
b0e5a6e
to
bbe66a7
Compare
gf712
reviewed
Aug 6, 2020
gf712
reviewed
Aug 6, 2020
gf712
reviewed
Aug 6, 2020
gf712
reviewed
Aug 6, 2020
| "Number of training vectors ({}) does not match number of " | ||
| "labels ({})", | ||
| data->get_num_vectors(), m_labels->get_num_labels()); | ||
|
|
There was a problem hiding this comment.
move these checks to NonParametricMachine::train
gf712
reviewed
Aug 6, 2020
gf712
reviewed
Aug 6, 2020
gf712
reviewed
Aug 6, 2020
gf712
reviewed
Aug 6, 2020
gf712
reviewed
Aug 6, 2020
|
Cool! I guess once this is merged we can start the PR against the develop branch :) |
LiuYuHui
force-pushed
the
refacter_all_machine
branch
from
7ed2a91
to
a6578c4
Compare
gf712
reviewed
Aug 6, 2020
| @@ -50,7 +50,8 @@ TEST_F(PipelineTest, fit_predict) | |||
| ->then(machine); | |||
|
|
|||
| // no labels given | |||
| EXPECT_THROW(pipeline->train(features), ShogunException); | |||
| //EXPECT_THROW(pipeline->train(features), ShogunException); | |||
| //pipeline->train(features, labels); | |||
There was a problem hiding this comment.
now pipeline have two train method, original train will not throw a exception.
|
@LiuYuHui Can I merge this? |
gf712
pushed a commit
that referenced
this pull request
Dec 8, 2020
* refactor all machines * fix unit test * fix python legacy and jupyter notebook
gf712
pushed a commit
that referenced
this pull request
Dec 8, 2020
* refactor all machines * fix unit test * fix python legacy and jupyter notebook
gf712
pushed a commit
that referenced
this pull request
Dec 8, 2020
* refactor all machines * fix unit test * fix python legacy and jupyter notebook
gf712
pushed a commit
that referenced
this pull request
Dec 8, 2020
* refactor all machines * fix unit test * fix python legacy and jupyter notebook
gf712
pushed a commit
that referenced
this pull request
Dec 8, 2020
* refactor all machines * fix unit test * fix python legacy and jupyter notebook
gf712
pushed a commit
that referenced
this pull request
Dec 8, 2020
* refactor all machines * fix unit test * fix python legacy and jupyter notebook
gf712
pushed a commit
that referenced
this pull request
Dec 8, 2020
* refactor all machines * fix unit test * fix python legacy and jupyter notebook
gf712
pushed a commit
that referenced
this pull request
Dec 8, 2020
* refactor all machines * fix unit test * fix python legacy and jupyter notebook
gf712
pushed a commit
that referenced
this pull request
Dec 8, 2020
* refactor all machines * fix unit test * fix python legacy and jupyter notebook
gf712
pushed a commit
that referenced
this pull request
Dec 8, 2020
* refactor all machines * fix unit test * fix python legacy and jupyter notebook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.