[WIP]Refactor MulticlassMachine #5101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gf712
reviewed
Jul 23, 2020
gf712
reviewed
Jul 23, 2020
gf712
reviewed
Jul 23, 2020
gf712
reviewed
Jul 23, 2020
gf712
reviewed
Jul 23, 2020
|
I guess this just has to be cleaned up a bit manually. And then can see if the compiler still throws errors, in which case there might be a class missing |
gf712
reviewed
Jul 24, 2020
gf712
reviewed
Jul 24, 2020
| @@ -64,6 +64,8 @@ class SVM : public KernelMachine | |||
| */ | |||
| SVM(float64_t C, std::shared_ptr<Kernel> k, std::shared_ptr<Labels> lab); | |||
There was a problem hiding this comment.
do you still need this constructor?
gf712
reviewed
Jul 24, 2020
gf712
reviewed
Jul 24, 2020
gf712
reviewed
Jul 24, 2020
gf712
reviewed
Jul 24, 2020
| /* changing the subset structure to use subset stacks. This might | ||
| * have to be revised. Heiko Strathmann */ | ||
| m_features->remove_subset(); | ||
|
|
There was a problem hiding this comment.
if these methods becomes noops can they just be removed? How are the subsets handled now?
There was a problem hiding this comment.
just add/remove subset to feature that will be passed in train_machine.
gf712
reviewed
Jul 24, 2020
gf712
reviewed
Jul 24, 2020
LiuYuHui
force-pushed
the
refacter_multiclass_machine
branch
from
ed3e315
to
aa02ae7
Compare
LiuYuHui
force-pushed
the
refacter_multiclass_machine
branch
from
aa02ae7
to
ef95d18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix by shogun-toolbox/shogun-libtooling#2