Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port classifier examples #4988

Merged
merged 12 commits into from
Apr 4, 2020

Conversation

Khalifa1997
Copy link
Contributor

with reference to issue #3555

Copy link
Member

@karlnapf karlnapf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! :)
I put some comments to start with

@Khalifa1997
Copy link
Contributor Author

thanks! :)
I put some comments to start with

I will work on them as soon as I can thanks :)

@gf712
Copy link
Member

gf712 commented Apr 2, 2020

Is there a corresponding python file that can be deleted?

@Khalifa1997
Copy link
Contributor Author

Is there a corresponding python file that can be deleted?

Deleted

@@ -0,0 +1,34 @@
CSVFile f_feats_train("@SHOGUN_DATA@/classifier_4class_2d_linear_features_train.dat")
CSVFile f_feats_test("@SHOGUN_DATA@/classifier_4class_2d_linear_features_test.dat")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filename change pls, see comment above

Copy link
Member

@karlnapf karlnapf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to merge once the ci is happy

@Khalifa1997 Khalifa1997 force-pushed the port_classifier_examples branch from 6a2fda3 to d0b477e Compare April 3, 2020 18:45
@karlnapf karlnapf merged commit 9aadc70 into shogun-toolbox:develop Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants