Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Classification notebook with new API #4825

Merged
merged 2 commits into from
Feb 18, 2020
Merged

Update Classification notebook with new API #4825

merged 2 commits into from
Feb 18, 2020

Conversation

zwasd
Copy link
Contributor

@zwasd zwasd commented Feb 16, 2020

gf712
gf712 reviewed Feb 16, 2020
View reviewed changes
.gitignore Outdated
@@ -185,6 +185,9 @@ Session.vim
*~
tags

# VS Code
.vscode

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using vscode mainly, and don't want to accidentally commit the settings folder

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's fine, but you shouldn't push your local .gitignore as not everyone uses .vscode

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i'll remove it

@gf712
Copy link
Member

gf712 commented Feb 16, 2020 •
edited
Loading

Looks good, did you test it locally?
Do you know how many aren't working?

@zwasd
Copy link
Contributor Author

zwasd commented Feb 16, 2020 •
edited
Loading

Looks good, did you test it locally?

I've run it in jupyter notebook, all the code seems to work

@vigsterkr
Copy link
Member

@zwasd could you plz just push the commit that doesn't add the .gitignore changes, i'd really like to merge this into develop!

@zwasd
Copy link
Contributor Author

zwasd commented Feb 18, 2020

@vigsterkr I've pushed them

@vigsterkr vigsterkr merged commit 88ce47a into shogun-toolbox:develop Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gf712 gf712 gf712 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zwasd @gf712 @vigsterkr