Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add meta example for ChiSquare Distance #4168

Closed
wants to merge 1 commit into from
Closed

Add meta example for ChiSquare Distance #4168

wants to merge 1 commit into from

Conversation

syashakash
Copy link
Contributor

Refer #3555
All tests passed.

@syashakash
Copy link
Contributor Author

unit-SGObject encounters Segmentation Fault, but the test works fine locally. I would get back to this later this week. I can't figure out what could possibly have gone wrong!!

@syashakash
Copy link
Contributor Author

Added data file for this example.

karlnapf
karlnapf requested changes Feb 19, 2018
View reviewed changes
Copy link
Member

@karlnapf karlnapf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example is fine, thx for that!

Could you add the data revision to the commit? (after the data PR was merged)

The segfault is not your fault and should not happen in the latest develop branch

@syashakash
Copy link
Contributor Author

Added data revision to this PR.

@karlnapf
Copy link
Member

Thanks!
We will need to wait with merging this, as there currently is a problem with the internal tests that needs fixing first (and likely update of the data file).

@syashakash
Copy link
Contributor Author

Agreed :)

@vigsterkr
Copy link
Member

@syashakash could you rebase this with the latest develop as the integration test is back.

@syashakash
Copy link
Contributor Author

syashakash commented Mar 6, 2018 •
edited
Loading

Ok, I see that the integration tests have failed! I would see how to solve this. I forgot to update the data file!!! I would be careful with not troubling Travis again!

karlnapf
karlnapf reviewed Mar 7, 2018
View reviewed changes
examples/meta/src/distance/chisquare.sg Outdated
@@ -0,0 +1,20 @@
CSVFile f_feats_a("../../data/fm_train_real.dat")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls rename the file to chi_square

@syashakash
Copy link
Contributor Author

@karlnapf @vigsterkr this example fails the new binary kernel SVM integration tests for ChiSquareDistance. The example's code is similar to that of other distance examples. I can't understand where the code fails as it does what it is supposed to do.

@karlnapf
Copy link
Member

karlnapf commented Mar 7, 2018

The integration test fails if the listing produces different data than the one in the reference data. See the examples and the development readme

@syashakash syashakash force-pushed the add-chisquare branch 2 times, most recently from 6feeeed to 2ca67c0 Compare March 13, 2018 07:09
@syashakash syashakash changed the title Add meta example for ChiSquare Distance [WIP]Add meta example for ChiSquare Distance Mar 13, 2018
@karlnapf
Copy link
Member

Shall we get this merged?

@syashakash
Copy link
Contributor Author

syashakash commented Mar 23, 2018 •
edited
Loading

@karlnapf the integration tests fail locally. Moreover, the data file needs another update, and this PR has wrong file. I will have to send a PR first to data for removal of the old file, then a PR update here to get this correct. A PR again to data then an update here, as soon as the integration tests pass.

@karlnapf
Copy link
Member

karlnapf commented Apr 2, 2018

Sure, wanna go ahead with that?

@karlnapf
Copy link
Member

karlnapf commented Apr 2, 2018

There now also is a merge conflict, so you will need to update this PR

@syashakash syashakash force-pushed the add-chisquare branch 2 times, most recently from 89457e3 to e0b915e Compare April 14, 2018 12:04
@syashakash syashakash changed the title [WIP]Add meta example for ChiSquare Distance Add meta example for ChiSquare Distance Apr 14, 2018
@stale
Copy link

stale bot commented Feb 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 26, 2020
@stale
Copy link

stale bot commented Mar 4, 2020

This issue is now being closed due to a lack of activity. Feel free to reopen it.

@stale stale bot closed this Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlnapf karlnapf karlnapf requested changes

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@syashakash @karlnapf @vigsterkr