why do we create twice the CrossvalidationSplitting objects

[vigsterkr]

shogun/src/shogun/statistical_testing/internals/mmd/CrossValidationMMD.h

Lines 198 to 206 in 40f40f0

	auto instance_x=new CCrossValidationSplitting(new CBinaryLabels(dummy_labels_x), m_num_folds);
	auto instance_y=new CCrossValidationSplitting(new CBinaryLabels(dummy_labels_y), m_num_folds);
	random::seed(instance_x, prng);
	random::seed(instance_y, prng);
	m_kfold_x=unique_ptr<CCrossValidationSplitting>(instance_x);
	m_kfold_y=unique_ptr<CCrossValidationSplitting>(instance_y);
	random::seed(m_kfold_x.get(), prng);
	random::seed(m_kfold_y.get(), prng);

[vigsterkr]

ok i've just realised that the second time it is just wrapped by a unique_ptr (i read it for some reason std::make_unique), still i'm not so sure why do we seed it twice? :)

[vigsterkr]

@theartful why do we seed there twice the same object?

[ghost]

@vigsterkr It's a mistake on my part. Using std::make_unique and seeding once is enough.

[vigsterkr]

@theartful ok thnx for confirming!
@lambday seems we need to update unit tests for xval mmd

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.