Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: recording filename typo, settings parameter set correctly #1604

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Fix: recording filename typo, settings parameter set correctly #1604

merged 1 commit into from
Oct 16, 2024

Conversation

AppPear
Copy link
Contributor

@AppPear AppPear commented Oct 16, 2024

Description & motivation

in startRecording it fileName was miss typed to filaName and settings parameter was unused.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@AppPear AppPear force-pushed the fix-recording-setting-filename branch from 1267e26 to e390793 Compare October 16, 2024 15:04
shogo4405
shogo4405 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Owner

@shogo4405 shogo4405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shogo4405 shogo4405 merged commit 9e6c626 into shogo4405:main Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shogo4405 shogo4405 shogo4405 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AppPear @shogo4405