Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Every FLV frame has key type #1515

Closed
levs42 opened this issue Jul 18, 2024 · 1 comment · Fixed by #1516
Closed

Every FLV frame has key type #1515

levs42 opened this issue Jul 18, 2024 · 1 comment · Fixed by #1516
Milestone
1.9.2

Comments

@levs42
Copy link
Contributor

levs42 commented Jul 18, 2024

Describe the bug

Every frame sets keyframe value to true here. It worked in 1.8.0, keyframe appears approximately every 2 seconds. It stopped working in 1.8.1, keyframe is always true.

To Reproduce

  1. Add print("keyframe: \(keyframe)") to sample project here
  2. Start stream
  3. Observe that keyframe is always true

Expected behavior

To set keyframe every 2 seconds

Version

1.9.1

Smartphone info.

iPhone 15 Pro Max

Additional context

No response

Screenshots

No response

Relevant log output

No response
@shogo4405 shogo4405 added this to the 1.9.2 milestone Jul 18, 2024
@shogo4405 shogo4405 added the bug label Jul 18, 2024
shogo4405 added a commit that referenced this issue Jul 18, 2024
@shogo4405
fixed #1515
d7e2647
@shogo4405 shogo4405 mentioned this issue Jul 18, 2024
Merged
1 task
shogo4405 added a commit that referenced this issue Jul 18, 2024
@shogo4405
Merge pull request #1516 from shogo4405/feature/fix-always-keyframe
efe5f1d 
fixed #1515 Every FLV frame has key type
@shogo4405
Copy link
Owner

Thank you feedback.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.2
Development

Successfully merging a pull request may close this issue.

fixed #1515 Every FLV frame has key type shogo4405/HaishinKit.swift
2 participants
@shogo4405 @levs42