Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add German translation #609

Closed
wants to merge 1 commit into from
Closed

Add German translation #609

wants to merge 1 commit into from

Conversation

peschee
Copy link
Contributor

@peschee peschee commented Dec 7, 2021

No description provided.

@vercel
Copy link

vercel bot commented Dec 7, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shoelace/shoelace/3jAa8qsHTogn6ccLFgUJnUxdP9BR
✅ Preview: https://shoelace-git-fork-peschee-patch-1-shoelace.vercel.app

@peschee
Copy link
Contributor Author

peschee commented Dec 7, 2021

Ah, saw this is already being handled in #608.

@peschee peschee closed this Dec 7, 2021
@peschee peschee deleted the patch-1 branch December 7, 2021 08:06
@trailsnail
Copy link
Contributor

Ah, saw this is already being handled in #608.

Sorry, I was a little bit faster this morning with my ☕ 😉

@peschee
Copy link
Contributor Author

peschee commented Dec 7, 2021

No worries at all @trailsnail

For me as a Swiss, there's still room for a de_CH translation :)

@trailsnail
Copy link
Contributor

No worries at all @trailsnail

For me as a Swiss, there's still room for a de_CH translation :)

Sehr gut 👍🏻 Perfekt 😄

@peschee
Copy link
Contributor Author

peschee commented Dec 7, 2021

@claviska Is this something you want to support?

German (Switzerland) > https://lh.2xlibre.net/locale/de_CH/

@claviska
Copy link
Member

claviska commented Dec 7, 2021

@claviska Is this something you want to support?

Yes! The localization lib supports language codes + country codes, so your $code will be de-CH.

The recommendation is to always load a base translation de and then optionally load additional regions to provide a better experience.

peschee added a commit to peschee/shoelace that referenced this pull request Dec 7, 2021
@peschee
Add de_CH translation
6854809 
Region-specific translation for German (Switzerland). 

Initiated from here: shoelace-style#609 (comment)
@peschee peschee mentioned this pull request Dec 7, 2021
Merged
claviska pushed a commit that referenced this pull request Dec 7, 2021
@peschee
Add de_CH translation (#611)
2937dbf 
Region-specific translation for German (Switzerland). 

Initiated from here: #609 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peschee @trailsnail @claviska