Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tab-group active indicator when tabs size change #2164

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Fix tab-group active indicator when tabs size change #2164

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f538ce3
Fix tab-group active indicator when tabs size change
aslushnikov Sep 9, 2024
27e7131
fix prettier
aslushnikov Sep 9, 2024
531a501
fix eslint
aslushnikov Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/components/tab-group/tab-group.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { watch } from '../../internal/watch.js';
import componentStyles from '../../styles/component.styles.js';
import ShoelaceElement from '../../internal/shoelace-element.js';
import SlIconButton from '../icon-button/icon-button.component.js';
import SlResizeObserver from '../resize-observer/resize-observer.component.js';
import styles from './tab-group.styles.js';
import type { CSSResultGroup } from 'lit';
import type SlTab from '../tab/tab.js';
Expand Down Expand Up @@ -42,7 +43,7 @@ import type SlTabPanel from '../tab-panel/tab-panel.js';
*/
export default class SlTabGroup extends ShoelaceElement {
static styles: CSSResultGroup = [componentStyles, styles];
static dependencies = { 'sl-icon-button': SlIconButton };
static dependencies = { 'sl-icon-button': SlIconButton, 'sl-resize-observer': SlResizeObserver };

private readonly localize = new LocalizeController(this);

Expand Down Expand Up @@ -437,7 +438,9 @@ export default class SlTabGroup extends ShoelaceElement {
<div class="tab-group__nav">
<div part="tabs" class="tab-group__tabs" role="tablist">
<div part="active-tab-indicator" class="tab-group__indicator"></div>
<slot name="nav" @slotchange=${this.syncTabsAndPanels}></slot>
<sl-resize-observer @sl-resize=${this.syncIndicator}>
<slot name="nav" @slotchange=${this.syncTabsAndPanels}></slot>
</sl-resize-observer>
</div>
</div>

Expand Down
Loading