#2078: Send event if image load fails, update changelog closes #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
If you're interested in this feature, LMK, and I can also add to the "should not render the image when the image fails to load" unit test. |
claviska
approved these changes
Jul 29, 2024
|
Thanks for the PR! I'm fine with this with one minor suggestion. Feel free to add a test if you'd like. |
|
Renamed, added test |
claviska
approved these changes
Jul 29, 2024
| @@ -62,7 +70,7 @@ export default class SlAvatar extends ShoelaceElement { | |||
| src="${this.image}" | |||
| loading="${this.loading}" | |||
| alt="" | |||
| @error="${() => (this.hasError = true)}" | |||
| @error="${this.onImageLoadError}" | |||
There was a problem hiding this comment.
Suggested change
| @error="${this.onImageLoadError}" | |
| @error="${this.handleImageLoadError}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2122