-
-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sl-select does not close when clicking outside #1859
Closed
Antony92 opened this issue
Feb 8, 2024
· 2 comments
· Fixed by #1878 or patooworld/nginx-1.25.4#4 · May be fixed by patooworld/pwa-starter#4, patooworld/nginx-1.25.4#11 or TaylorBundy/swiper#3
Closed
sl-select does not close when clicking outside #1859
Antony92 opened this issue
Feb 8, 2024
· 2 comments
· Fixed by #1878 or patooworld/nginx-1.25.4#4 · May be fixed by patooworld/pwa-starter#4, patooworld/nginx-1.25.4#11 or TaylorBundy/swiper#3
Labels
bug
Things that aren't working right in the library.
Comments
After checking the code maybe root.addEventListener('focusin', this.handleDocumentFocusIn);
document.addEventListener('keydown', this.handleDocumentKeyDown);
document.addEventListener('mousedown', this.handleDocumentMouseDown); |
PR created |
This was referenced Feb 20, 2024
claviska
added a commit
that referenced
this issue
Feb 20, 2024
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
It seems that adding sl-select in shadowDOM breaks the close outside functionality. This was not present in version 2.12 and started to happen in 2.13 due to this PR
To Reproduce
Steps to reproduce the behavior:
Demo
CodePen
Browser / OS
Additional information
Most likely the issue is from switching
document
togetRootNode()
The text was updated successfully, but these errors were encountered: