fix: omit undefined query condition for no package_hash update check

shm-open · Aug 23, 2021 · 6dbe8df · 6dbe8df
1 parent 247a7ab
commit 6dbe8df
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/core/services/client-manager.js b/core/services/client-manager.js
@@ -211,10 +211,13 @@ proto.updateCheck = function (deploymentKey, appVersion, label, packageHash, cli
                         !_.eq(_.get(packages, 'package_hash', ''), packageHash)
                     ) {
                         return models.PackagesDiff.findOne({
-                            where: {
-                                package_id: packages.id,
-                                diff_against_package_hash: packageHash,
-                            },
+                            where: _.omitBy(
+                                {
+                                    package_id: packages.id,
+                                    diff_against_package_hash: packageHash,
+                                },
+                                _.isUndefined,
+                            ),
                         }).then((diffPackage) => {
                             if (!_.isEmpty(diffPackage)) {
                                 rs.downloadURL = common.getBlobDownloadUrl(