Remove name and uniqueness in redirect condition table #2035
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1914
During the implementation of the API to handle redirect rules and conditions, it was made obvious that a normalized version of rules<->relation_table<->conditions would not be as easy to handle, so I thought it would make more sense to switch from a many-to-many relationship to a one-to-many.
However, we want rules to know about conditions, but not the other way around, and Doctrine does not handle inversed unidirectional one-to-many relationships so well.
Because of that, this keeps the many-to-many relationship, but refactoring it so that conditions are not unique nor shared between rules anymore. Instead, every rule will have its conditions, that will be removed when orphaned.
That requires removing the
name
filed from conditions, which acted as a unique key, and making conditions to cascade persist, as they will always be created together with "their" rule.