Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/visits threshold fix #154

Merged
merged 2 commits into from
Feb 18, 2022

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Feb 18, 2022

@codecov-commenter
Copy link

Codecov Report

Merging #154 (40a8807) into main (a1d30e1) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #154      +/-   ##
============================================
- Coverage     97.94%   97.83%   -0.11%     
+ Complexity      279      277       -2     
============================================
  Files            73       73              
  Lines           681      648      -33     
============================================
- Hits            667      634      -33     
  Misses           14       14              
Impacted Files Coverage Δ
...onfig/Option/Visit/VisitsThresholdConfigOption.php 100.00% <100.00%> (ø)
src/Config/Util/ConfigOptionsValidatorsTrait.php 100.00% <100.00%> (ø)
src/Util/AskUtilsTrait.php 40.00% <0.00%> (-10.00%) ⬇️
...ig/Option/Worker/AbstractWorkerNumConfigOption.php 77.77% <0.00%> (-2.23%) ⬇️
src/Config/ConfigGenerator.php 96.00% <0.00%> (-0.67%) ⬇️
src/Util/Utils.php 100.00% <0.00%> (ø)
src/Model/ImportedConfig.php 100.00% <0.00%> (ø)
src/Command/UpdateCommand.php 100.00% <0.00%> (ø)
src/Command/InstallCommand.php 100.00% <0.00%> (ø)
src/Command/SetOptionCommand.php 100.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1d30e1...40a8807. Read the comment docs.

@acelaya acelaya merged commit 0181942 into shlinkio:main Feb 18, 2022
@acelaya acelaya deleted the feature/visits-threshold-fix branch February 18, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants