Fix apparent typo #501
Merged
Fix apparent typo #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the PHPCPD and PHPUnit tools use the [same function under the hood](https://github.com/shivammathur/setup-php/blob/1fa3ba1b162e818eed12eed233c9837299574948/src/tools.ts#L461-L473), I have the impression that the `function` keyword should be the tool name. If that's correct, this should fix it.
jrfnl
force-pushed
the
feature/fix-typo
branch
from
dca6fce to
608ad1a
Compare
|
@jrfnl Thanks! |
|
yvw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: 🐞 Bug Fix
about: You found a bug
labels: bug
A Pull Request should be associated with a Discussion.
N/A
Description
While the PHPCPD and PHPUnit tools use the same function under the hood, I have the impression that the
functionkeyword should be the tool name.If that's correct, this should fix it.
This change is already covered by existing tests
npm run formatbefore the commit.npm run lintbefore the commit.npm run releasebefore the commit.npm testreturns with no unit test errors and all code covered.