Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[process] implement ParentWithContext using PpidWithContext #1235

Merged
merged 2 commits into from
Jan 30, 2022

Conversation

scop
Copy link
Contributor

@scop scop commented Jan 22, 2022

Removes need for redundant ParentWithContext implementations. It had led to it being unsupported on FreeBSD and OpenBSD even though PpidWithContext was available for them, and different implementations for getting the parent info used in ParentWithContext and PpidWithContext on Darwin and Linux.

For Darwin and Linux, I just dropped the separate ParentWithContext implementation. Let me know if you would have preferred the internals of that to be moved over to PpidWithContext instead.

Removes need for redundant ParentWithContext implementations. It had led
to it being unsupported on FreeBSD and OpenBSD even though
PpidWithContext was available for them, and different implementations
for getting the parent info used in ParentWithContext and
PpidWithContext on Darwin and Linux.
Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you so much!

@shirou shirou merged commit 696bb11 into shirou:master Jan 30, 2022
@scop scop deleted the refactor/parentwithcontext-ppidwithcontext branch January 30, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants