Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose MemCommit info for Windows #1719

Closed
n4nn31355 opened this issue Oct 1, 2024 · 0 comments · Fixed by #1720
Closed

Expose MemCommit info for Windows #1719

n4nn31355 opened this issue Oct 1, 2024 · 0 comments · Fixed by #1720

Comments

@n4nn31355
Copy link
Contributor

n4nn31355 commented Oct 1, 2024

Is your feature request related to a problem? Please describe.
Windows basically doesn't allow to overcommit memory, and applications most times start to fail when there is enough physical memory available, so this is a critical metric for the platform.

Describe the solution you'd like
Expose CommitTotal and CommitLimit metrics.
It probably makes sense to also expose ullTotalPageFile and ullAvailPageFile, but I am less concerned about that.
This data is already being requested from the system, but not exposed.

Describe alternatives you've considered
[A clear and concise description of any alternative solutions or features you've considered.]

Additional context
Example of the difference between Used/Commited memory in Windows Task Manager:
image
Stats doc:
https://learn.microsoft.com/en-us/windows/win32/api/psapi/ns-psapi-performance_information#members
https://learn.microsoft.com/en-us/windows/win32/memory/memory-performance-information#system-memory-performance-information

n4nn31355 added a commit to n4nn31355/gopsutil that referenced this issue Oct 3, 2024
Closes Expose MemCommit info for Windows shirou#1719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant