Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add git error parser and surfacing of git errors #972

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Add git error parser and surfacing of git errors #972

merged 1 commit into from
Jan 11, 2022

Conversation

dalbar
Copy link
Member

@dalbar dalbar commented Jan 3, 2022 •
edited by SaschaSchwarze0
Loading

Changes

This PR implements a parser and interpreter for git errors in stdout and surfaces them as error results.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

In case of failures during the Git source step, further error details are now made available in `.status.failureDetails`.

@openshift-ci openshift-ci bot added release-note-none Label for when a PR does not need a release note do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 3, 2022
@dalbar dalbar changed the title Add/git error parser Add git error parser and surfacing of git errors Jan 4, 2022
@dalbar dalbar force-pushed the add/git-error-parser branch from 5a7c115 to 98f688e Compare January 4, 2022 16:08
@dalbar dalbar marked this pull request as ready for review January 4, 2022 16:08
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 4, 2022
@dalbar
Copy link
Member Author

dalbar commented Jan 4, 2022

/kind feature

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 4, 2022
@dalbar dalbar force-pushed the add/git-error-parser branch from 98f688e to fac8659 Compare January 5, 2022 13:34
@dalbar dalbar marked this pull request as draft January 5, 2022 15:16
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2022
@dalbar dalbar force-pushed the add/git-error-parser branch from fac8659 to f919ca4 Compare January 7, 2022 07:34
@dalbar dalbar marked this pull request as ready for review January 7, 2022 08:18
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2022
@dalbar dalbar marked this pull request as draft January 7, 2022 08:18
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2022
@dalbar dalbar force-pushed the add/git-error-parser branch 6 times, most recently from 4e1e29b to 7c43b67 Compare January 7, 2022 10:17
@dalbar dalbar marked this pull request as ready for review January 7, 2022 11:04
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2022
SaschaSchwarze0
SaschaSchwarze0 requested changes Jan 10, 2022
View reviewed changes
cmd/git/main.go Outdated Show resolved Hide resolved
cmd/git/main.go Outdated Show resolved Hide resolved
cmd/git/main_test.go Outdated Show resolved Hide resolved
test/e2e/e2e_test.go Outdated Show resolved Hide resolved
@dalbar dalbar force-pushed the add/git-error-parser branch from 7c43b67 to 5be3410 Compare January 10, 2022 16:30
shahulsonhal
shahulsonhal suggested changes Jan 11, 2022
View reviewed changes
Copy link
Member

@shahulsonhal shahulsonhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

cmd/git/main.go Outdated Show resolved Hide resolved
cmd/git/main.go Outdated Show resolved Hide resolved
cmd/git/main.go Show resolved Hide resolved
pkg/git/error_parser.go Outdated Show resolved Hide resolved
cmd/git/main_test.go Outdated Show resolved Hide resolved
@dalbar dalbar force-pushed the add/git-error-parser branch from 5be3410 to 89372a1 Compare January 11, 2022 07:28
@dalbar dalbar force-pushed the add/git-error-parser branch 2 times, most recently from df19a02 to 55323f5 Compare January 11, 2022 07:44
shahulsonhal
shahulsonhal suggested changes Jan 11, 2022
View reviewed changes
cmd/git/main_test.go Outdated Show resolved Hide resolved
pkg/git/error_parser.go Outdated Show resolved Hide resolved
@dalbar dalbar force-pushed the add/git-error-parser branch from 55323f5 to 20a3146 Compare January 11, 2022 10:53
Added git-err parsing and surface failures
a201a1e 
Adds Parser that processes git stdout

Git cmd line tool now uses error results to surface detailed reason and message
@dalbar dalbar force-pushed the add/git-error-parser branch from 20a3146 to a201a1e Compare January 11, 2022 11:07
@dalbar dalbar requested a review from shahulsonhal January 11, 2022 11:08
shahulsonhal
shahulsonhal approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@shahulsonhal shahulsonhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2022
gabemontero
gabemontero approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@gabemontero gabemontero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2022
@openshift-merge-robot openshift-merge-robot merged commit 57ded83 into shipwright-io:main Jan 11, 2022
@openshift-ci openshift-ci bot added release-note Label for when a PR has specified a release note and removed release-note-none Label for when a PR does not need a release note labels Jan 14, 2022
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.8.0 milestone Jan 14, 2022
@dalbar dalbar deleted the add/git-error-parser branch February 26, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahulsonhal shahulsonhal shahulsonhal approved these changes

@gabemontero gabemontero gabemontero approved these changes

@HeavyWombat HeavyWombat Awaiting requested review from HeavyWombat

@SaschaSchwarze0 SaschaSchwarze0 Awaiting requested review from SaschaSchwarze0

Assignees

@shahulsonhal shahulsonhal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Milestone
release-v0.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dalbar @gabemontero @shahulsonhal @SaschaSchwarze0 @openshift-merge-robot