Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag nightly releases to avoid quay GC #690

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

imjasonh
Copy link
Contributor

Changes

Update nightly release workflow to add a tag to images it produces, like :nightly-{date}-{seconds}

Quay.io aggressively garbage collects untagged manifests, so our nightly release images are no longer available after a few days, for example @sha256:a930c8 from our 2021-03-18 nightly release.

Applying tags to these images should keep them from getting GCed.

/kind bug

Submitter Checklist

  • [n] Includes tests if functionality changed/was added
  • [n] Includes docs if changes are user-facing
  • [y] Set a kind label on this PR
  • [y] Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Tag nightly release images to avoid registry garbage collection

/assign @qu1queee

@openshift-ci-robot openshift-ci-robot added release-note Label for when a PR has specified a release note kind/bug Categorizes issue or PR as related to a bug. labels Mar 23, 2021
@qu1queee qu1queee self-requested a review March 24, 2021 08:17
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this will work.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2021
@openshift-merge-robot openshift-merge-robot merged commit c27504c into shipwright-io:master Mar 24, 2021
@qu1queee qu1queee added this to the release-v0.4.0 milestone Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants