Restructure controllers pkg #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
release-note
openshift-ci-robot
added
the
needs-rebase
qu1queee
force-pushed
the
qu1queee/refactor_controllers_struct
branch
from
aa658a3
to
7fc15f0
Compare
openshift-ci-robot
removed
the
needs-rebase
This introduce reconciler pkg, this package provides more clarity between controller and reconciler logic. It also allows each resource to have an internal resources package to deal with all related resources involved during that resource reconciliation.
qu1queee
force-pushed
the
qu1queee/refactor_controllers_struct
branch
from
7fc15f0
to
6cad175
Compare
qu1queee
requested review from
HeavyWombat and
SaschaSchwarze0
and removed request for
zhangtbj
3 tasks
HeavyWombat
requested changes
Feb 17, 2021
Fix all sanity check linters Add all missing license headers
Do not include markdown files under .github dir
qu1queee
force-pushed
the
qu1queee/refactor_controllers_struct
branch
from
6cad175
to
c7c4fde
Compare
SaschaSchwarze0
approved these changes
Feb 17, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
HeavyWombat
approved these changes
Feb 17, 2021
|
/lgtm |
gabemontero
added
the
kind/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This came up while working on #558 . This does NOT fix #558, this is a general code structure enhancement around controllers definition and reconcile logic.
The goal of this PR is to make the code definition more clear, for future contributors and future enhancements.
This PR provides:
/pkg/controllerto/pkg/reconciler. This provides more clarity on where the reconcile logic is.resources, to allocate all logic related to resources that required to be manage during reconciliations. This is only added at the moment for the buildrun one, at/pkg/reconciler/buildrun/resources./pkg/controllerpackage to host the manager definition based in all controllers definitions.The above is based on how
Tekton/Knativeorganize their project structures regarding reconcile and controllers logic.Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes
Note: We still have room for improvement on the code organization, mainly on the BuildRun reconciler logic. But adding an initial PR to avoid adding a larger one.