Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for the multiarch-native-buildah ClusterStrategy #1660

Merged

Conversation

aleskandro
Copy link
Contributor

@aleskandro aleskandro commented Aug 7, 2024

This PR proposes a new paragraph to document the Multiarch Native Buildah strategy proposed in #1634.

I see the other strategies leverage a relative path to link to the strategy in the document; however, those links are dead, AFAICU.

Therefore, I used GitHub permalinks. Are they okay with landing in the doc?

Relates to #1119

Release Notes

NONE

/kind documentation

Submitter Checklist

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 7, 2024
@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 7, 2024
@openshift-ci openshift-ci bot added release-note Label for when a PR has specified a release note release-note-none Label for when a PR does not need a release note and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Label for when a PR has specified a release note labels Aug 7, 2024
@aleskandro
Copy link
Contributor Author

/kind documentation

@openshift-ci openshift-ci bot added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 7, 2024
@aleskandro
Copy link
Contributor Author

/test "Release Note Linter / Release Note Linter (pull_request)"

Copy link
Contributor

openshift-ci bot commented Aug 7, 2024

@aleskandro: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test "Release Note Linter / Release Note Linter (pull_request)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aleskandro aleskandro force-pushed the doc-multiarch-native-builds branch from a89f251 to c4f18df Compare August 7, 2024 15:30
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.14.0 milestone Aug 10, 2024
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2024
Copy link
Contributor

openshift-ci bot commented Aug 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 58c1055 into shipwright-io:main Aug 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants