Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add legacy endpoints to registry detection #1628

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

HeavyWombat
Copy link
Contributor

Changes

Add the respective legacy/old registry endpoints to the list of endpoints of the registry detection to allow users to potentially still use the old registry endpoints.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

The bundle prune option now also supports the legacy registry endpoints for both DockerHub and IBM Container Registry in its registry detection routine.

@HeavyWombat HeavyWombat added the kind/bug Categorizes issue or PR as related to a bug. label Jun 20, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 20, 2024
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Jun 20, 2024
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check

if strings.Contains(registry, "stg.icr.io") {
. I think you need to add the stage bluemix endpoint there as well.

Add the respective legacy/old registry endpoints to the list of
endpoints of the registry detection to allow users to potentially still
use the old registry endpoints.
@HeavyWombat HeavyWombat force-pushed the add/legacy-endpoints branch from dce7c32 to c9a1b55 Compare June 21, 2024 07:00
@HeavyWombat
Copy link
Contributor Author

Please check

if strings.Contains(registry, "stg.icr.io") {

. I think you need to add the stage bluemix endpoint there as well.

Thanks!

Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2024
Copy link
Contributor

openshift-ci bot commented Jun 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 60fa094 into main Jun 21, 2024
14 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the add/legacy-endpoints branch June 21, 2024 08:40
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.14.0 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants