Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: buildkit insecure registry image caching #1239

Merged
merged 1 commit into from
Mar 16, 2023
Merged

fix: buildkit insecure registry image caching #1239

merged 1 commit into from
Mar 16, 2023

Conversation

mjgallag
Copy link
Contributor

@mjgallag mjgallag commented Mar 15, 2023

moby/buildkit@7bd7285

Changes

Fix buildkit cluster build strategy's cache import from insecure registry.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Fix buildkit cluster build strategy's cache import from insecure registry.

@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Mar 15, 2023
@openshift-ci openshift-ci bot requested review from otaviof and qu1queee March 15, 2023 19:36
@SaschaSchwarze0 SaschaSchwarze0 added the kind/bug Categorizes issue or PR as related to a bug. label Mar 16, 2023
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.12.0 milestone Mar 16, 2023
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mjgallag

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2023
@openshift-merge-robot openshift-merge-robot merged commit 1303639 into shipwright-io:main Mar 16, 2023
@mjgallag mjgallag deleted the fix-insecure-registry-image-caching branch March 16, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants