Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BuildAh --digestfile argument to store digest of pushed image #1029

Conversation

SaschaSchwarze0
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 commented Mar 30, 2022

Changes

Fixes #1028

Using the proposed approach by @nalind to store the digest of the pushed image in the BuildRun result. Much simpler than the previous workaround. :-)

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

Use BuildAh's `--digestfile` argument in the sample build strategies

@SaschaSchwarze0 SaschaSchwarze0 added the kind/bug Categorizes issue or PR as related to a bug. label Mar 30, 2022
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.9.0 milestone Mar 30, 2022
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Mar 30, 2022
@qu1queee qu1queee self-requested a review March 31, 2022 07:51
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice,

@gabemontero pls approve from your side if this looks accurate.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2022
@gabemontero
Copy link
Member

yep this looks in line with my interpretation of @nalind 's super helpful summary in #1028 (comment)

I will

/approve

for merge.

@nalind - if you have 2 seconds to eyeball the change, please do and post any comments here. If by chance there is some tweak we need, we can follow up separately. Thanks again.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2022
@openshift-merge-robot openshift-merge-robot merged commit 9a40e9c into shipwright-io:main Mar 31, 2022
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-1028-buildah-image-digest branch March 31, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow-up on BuildAh image digest logic
4 participants