Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use secure way to access parameter values in inline scripts #1012

Conversation

SaschaSchwarze0
Copy link
Member

Changes

Changing the sample build strategies to use a secure way to access parameter values that does not allow code injection.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

All sample build strategies now use a documented secure approach to access parameter values that does not allow code injection

@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Mar 17, 2022
@openshift-ci openshift-ci bot requested review from qu1queee and sbose78 March 17, 2022 20:12
@SaschaSchwarze0 SaschaSchwarze0 added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 17, 2022
@gabemontero
Copy link
Member

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2022
docs/buildstrategies.md Outdated Show resolved Hide resolved
@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-build-strategy-updates branch 4 times, most recently from 5d28afa to 1b3b0ee Compare March 21, 2022 09:44
@qu1queee qu1queee requested review from qu1queee March 22, 2022 21:21
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good. I just have a question on a change in the Makefile, pls take a look.

Makefile Outdated Show resolved Hide resolved
@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-build-strategy-updates branch from 1b3b0ee to 9998ac3 Compare March 23, 2022 08:37
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@qu1queee
Copy link
Contributor

@adambkaplan can u take a look on this one pls

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero, qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gabemontero,qu1queee]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2022
@openshift-merge-robot openshift-merge-robot merged commit c5e815b into shipwright-io:main Mar 23, 2022
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.9.0 milestone Mar 24, 2022
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-build-strategy-updates branch March 28, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants