-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use secure way to access parameter values in inline scripts #1012
Use secure way to access parameter values in inline scripts #1012
Conversation
/approve |
5d28afa
to
1b3b0ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good. I just have a question on a change in the Makefile, pls take a look.
1b3b0ee
to
9998ac3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
@adambkaplan can u take a look on this one pls |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabemontero, qu1queee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Changes
Changing the sample build strategies to use a secure way to access parameter values that does not allow code injection.
Submitter Checklist
Release Notes