Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git source: prevent usage of a secret with HTTP protocol #1131

Closed
SaschaSchwarze0 opened this issue Oct 19, 2022 · 0 comments · Fixed by #1176
Closed

Git source: prevent usage of a secret with HTTP protocol #1131

SaschaSchwarze0 opened this issue Oct 19, 2022 · 0 comments · Fixed by #1176
Assignees
@HeavyWombat
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@SaschaSchwarze0
Copy link
Member

SaschaSchwarze0 commented Oct 19, 2022 •
edited
Loading

Related to #1116

In https://github.com/shipwright-io/build/blob/main/cmd/git/main.go#L487-L502, we have handling for the credential that is passed to the Git step and check if it matches the protocol. There, we ignored HTTP. What we decided is that we want a check and bail out with a clear error if HTTP is used with any type of credentials.
@SaschaSchwarze0 SaschaSchwarze0 added kind/bug Categorizes issue or PR as related to a bug. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Oct 19, 2022
@SaschaSchwarze0 SaschaSchwarze0 mentioned this issue Oct 19, 2022
Open
HeavyWombat added a commit that referenced this issue Dec 22, 2022
@HeavyWombat
Add custom error for basic auth with HTTP
349d969 
Fixes: #1131

Ref: #1116

Check that basic auth is not used in combination with a HTTP endpoint.
@HeavyWombat HeavyWombat mentioned this issue Dec 22, 2022
Merged
4 tasks
HeavyWombat added a commit that referenced this issue Dec 22, 2022
@HeavyWombat
Add custom error for basic auth with HTTP
6dd8a26 
Fixes: #1131

Ref: #1116

Check that basic auth is not used in combination with a HTTP endpoint.
HeavyWombat added a commit that referenced this issue Dec 22, 2022
@HeavyWombat
Add custom error for basic auth with HTTP
74fa43f 
Fixes: #1131

Ref: #1116

Check that basic auth is not used in combination with a HTTP endpoint.
@HeavyWombat HeavyWombat self-assigned this Dec 23, 2022
HeavyWombat added a commit that referenced this issue Jan 4, 2023
@HeavyWombat
Add custom error for basic auth with HTTP
46ae1d4 
Fixes: #1131

Ref: #1116

Check that basic auth is not used in combination with a HTTP endpoint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HeavyWombat HeavyWombat

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add custom error for basic auth with HTTP shipwright-io/build
2 participants
@HeavyWombat @SaschaSchwarze0