Fix sanity checks and missing headers

Fix all sanity check linters
Add all missing license headers

.github/pull_request_template.md

@@ -1,3 +1,8 @@
+<!--
+Copyright The Shipwright Contributors
+
+SPDX-License-Identifier: Apache-2.0
+-->
 # Changes
 
 <!-- 🎉🎉🎉 Thank you for the PR!!! 🎉🎉🎉 -->

SECURITY.md

@@ -1,3 +1,8 @@
+<!--
+Copyright The Shipwright Contributors
+
+SPDX-License-Identifier: Apache-2.0
+-->
 # Shipwright Security and Disclosure Information
 
 Shipwright encourages all users and contributors to report potential security vulnerabilities to the project maintainers.

cmd/manager/main.go

@@ -125,7 +125,7 @@ func main() {
 	buildMetrics.InitPrometheus(buildCfg)
 
 	// Add optionally configured extra handlers to metrics endpoint
-	for path, handler := range buildMetrics.MetricsExtraHandlers() {
+	for path, handler := range buildMetrics.ExtraHandlers() {
 		ctxlog.Info(ctx, "Adding metrics extra handler path", "path", path)
 		if err := mgr.AddMetricsExtraHandler(path, handler); err != nil {
 			ctxlog.Error(ctx, err, "")

docs/proposals/dedicated-shipwright-operator.md

@@ -139,7 +139,7 @@ Deleting the `ShipwrightBuild` instance should remove the associated deployment
 However, the Build API CRDs will remain on the cluster, as these will be managed by OLM.
 
 At present, OLM does not delete CRDs and CRD instances if the associated operator is removed.
-This is by design to ensure user data is not accidently deleted - see [operator-framework/operator-lifecycle-manager#1326](https://github.com/operator-framework/operator-lifecycle-manager/issues/1326).
+This is by design to ensure user data is not accidentally deleted - see [operator-framework/operator-lifecycle-manager#1326](https://github.com/operator-framework/operator-lifecycle-manager/issues/1326).
 
 #### Installed Custom Resource Definitions
 
@@ -161,7 +161,7 @@ This would be useful if Project Shipwright produces additional components and cl
 **Risk**: Manifests uses to deploy Shipwright Builds in the `shipwright-io/operator` are not synchronized with content in `shipwright-io/build`.
 
 *Mitigation*: The operator's CI should include a test suite that runs the e2e tests in `shipwright-io/build`.
-Project maintainers should also ensure that deployment changes to `shipwright-io/build` carry accross to the operator.
+Project maintainers should also ensure that deployment changes to `shipwright-io/build` carry across to the operator.
 
 **Risk**: Operator will require permissions cluster admins will reject (ex - modify CRDs)
 

pkg/metrics/metrics.go

@@ -139,7 +139,8 @@ func InitPrometheus(config *config.Config) {
 	)
 }
 
-func MetricsExtraHandlers() map[string]http.HandlerFunc {
+// ExtraHandlers returns a map of additional endpoint handlers
+func ExtraHandlers() map[string]http.HandlerFunc {
 	return metricsExtraHandlers
 }
 

pkg/reconciler/build/build.go

@@ -1,3 +1,7 @@
+// Copyright The Shipwright Contributors
+//
+// SPDX-License-Identifier: Apache-2.0
+
 package build
 
 import (

pkg/reconciler/build/controller.go

@@ -1,3 +1,7 @@
+// Copyright The Shipwright Contributors
+//
+// SPDX-License-Identifier: Apache-2.0
+
 package build
 
 import (

pkg/reconciler/buildrun/buildrun.go

@@ -1,3 +1,7 @@
+// Copyright The Shipwright Contributors
+//
+// SPDX-License-Identifier: Apache-2.0
+
 package buildrun
 
 import (

pkg/reconciler/buildrun/buildrun_suite_test.go

@@ -1,3 +1,6 @@
+// Copyright The Shipwright Contributors
+//
+// SPDX-License-Identifier: Apache-2.0
 package buildrun_test
 
 import (

pkg/reconciler/buildrun/controller.go

@@ -1,3 +1,7 @@
+// Copyright The Shipwright Contributors
+//
+// SPDX-License-Identifier: Apache-2.0
+
 package buildrun
 
 import (

pkg/validate/ownerreferences.go

@@ -1,3 +1,7 @@
+// Copyright The Shipwright Contributors
+//
+// SPDX-License-Identifier: Apache-2.0
+
 package validate
 
 import (

pkg/validate/runtime.go

@@ -1,3 +1,7 @@
+// Copyright The Shipwright Contributors
+//
+// SPDX-License-Identifier: Apache-2.0
+
 package validate
 
 import (

pkg/validate/secrets.go

@@ -1,3 +1,7 @@
+// Copyright The Shipwright Contributors
+//
+// SPDX-License-Identifier: Apache-2.0
+
 package validate
 
 import (

pkg/validate/sourceurl.go

@@ -1,3 +1,7 @@
+// Copyright The Shipwright Contributors
+//
+// SPDX-License-Identifier: Apache-2.0
+
 package validate
 
 import (

pkg/validate/strategies.go

@@ -1,3 +1,7 @@
+// Copyright The Shipwright Contributors
+//
+// SPDX-License-Identifier: Apache-2.0
+
 package validate
 
 import (

pkg/validate/validate.go

@@ -1,3 +1,7 @@
+// Copyright The Shipwright Contributors
+//
+// SPDX-License-Identifier: Apache-2.0
+
 package validate
 
 import (