Step Element Target Action #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added getElement to Step class Added getTarget to Step class Added this context to Action callback typescript definition
|
@rwwagner90 did I do something wrong with my PR? |
RobbieTheWagner
approved these changes
Jun 8, 2020
|
@WORMSS no everything looks good! Sorry I just wanted to double check where the target was set, and I think we are okay here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @rwwagner90 Sorry, I have been some time, I have had family duties and also it seems I am being super dumb so it's really slowing me down.
I have never tried to do advanced things with JSdocs, so I am failing to see how I can nicely add the 'this' context to JSDocs.. I am more a typescript person who has dabbled with JSDocs in the past..
So I have utterly failed to see how to assign the context without making it look like a function argument, so.. I left it as is. (Sorry)
The second thing I have been struggling with is double checking on what
getTarget()could return..I was destroying my brain going around in circles over and over going down dead ends and all sorts trying to find where this.target was assigned in
step.js..And then I finally found
step.targetingeneral.jsandparseAttachToAdded getElement to Step class and typescript definition
Added getTarget to Step class and typescript definition
Added 'this' context to Action callback typescript definition
Though, I thought it best to note, it is technically possible to get SVGElements back and not just HTMLElements.. We have some Typescripting in our own projects that deal with that, but with how limiting it is with JSDocs already, I thought best to try and keep it simple and not defer too far from the JSDocs in the typescript definition.