Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling default middlewares using options.disableDefaultMiddlewares #3010

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

patrikholcak
Copy link
Contributor

About

Shepherd is adding some middlewares (afaik for historic reasons). Sometimes you might want to disable this behaviour and pass entirely different middlewares or add your own options to the default ones. In that case, it might be easier to disable them entirely and pass your own as default step options

Proposed changes

  • add StepOptions.disableDefaultMiddlewares?: bool
  • disable any middlewares which are added by default when this option is set

Maybe this isn’t needed after #3005, but I’m filing this just in case

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shepherd-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 5:36pm

Copy link

vercel bot commented Oct 11, 2024

@patrikholcak is attempting to deploy a commit to the shipshapecode Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant