Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix calls to setTimeout in tests #2046

Merged
merged 6 commits into from
Aug 29, 2022
Merged

Fix calls to setTimeout in tests #2046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9d962ae
update welcome.css
theodoreb Aug 29, 2022
8cdd26e
Don't display user errors during testing
theodoreb Aug 29, 2022
f34681b
fix call to setTimeout in test
theodoreb Aug 29, 2022
18e7928
Revert "Don't display user errors during testing"
theodoreb Aug 29, 2022
c1326e4
Revert "update welcome.css"
theodoreb Aug 29, 2022
3a4b859
Don't show console.errors during tests
theodoreb Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions test/unit/setupTests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,12 @@ import 'jest-expect-message';
import '@testing-library/jest-dom/extend-expect';
import 'mutationobserver-shim';


// Console errors are used for user information, do not display them during
// tests.
global.console = {
...console,
error: jest.fn()
};

global.sleep = (ms) => new Promise((resolve) => setTimeout(resolve, ms));
12 changes: 6 additions & 6 deletions test/unit/step.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ describe('Tour | Step', () => {
});

const beforeShowPromise = new Promise((resolve) => {
return setTimeout(1000, resolve('beforeShowPromise worked!'));
return setTimeout(() => resolve('beforeShowPromise worked!'), 1000);
});

const beforeShowPromiseTestStep = instance.addStep({
Expand Down Expand Up @@ -478,7 +478,7 @@ describe('Tour | Step', () => {
document.body.appendChild(resTester);

const beforeShowPromise = new Promise((resolve) => {
return setTimeout(1000, resolve('beforeShowPromise worked!'));
return setTimeout(() => resolve('beforeShowPromise worked!'), 1000);
});

const step = new Step('test', {
Expand All @@ -495,12 +495,12 @@ describe('Tour | Step', () => {
expect(resHandlerCalled).toBeTruthy();
expect(resSpy).toBeCalled();
})

it('calls the custom handler after before-show promise resolution', () => {
let resHandlerAdded = false;

const beforeShowPromise = new Promise((resolve) => {
return setTimeout(1000, resolve('beforeShowPromise worked!'));
return setTimeout(() => resolve('beforeShowPromise worked!'), 1000);
});

const step = new Step('test', {
Expand Down Expand Up @@ -726,9 +726,9 @@ describe('Tour | Step', () => {
expect(result1).not.toBeNull()

instance.next();

const result2 = instance.getById('step1')._getResolvedAttachToOptions();

expect(result1).toEqual(result2);
});

Expand Down