Add dynamic text and label properties for buttons #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @radibit, thanks for the PR! This is definitely a useful feature. Would you mind also updating the docs to mention these things can now be functions and how to use them, etc? |
|
@rwwagner90 Thank you for the quick response. I'll update the docs, good reminder 👍 |
RobbieTheWagner
approved these changes
Feb 25, 2022
|
Hey @rwwagner90 sorry to bother you but can I ask if there is a release in planning for the next version of Shepherd library which will include the change completed with this PR? ℹ️ Unfortunately, there isn't a way to point in my |
|
@radibit I released the other day. Sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks 👋
This PR:
textandlabelproperties for thebuttoncomponentbuttoncomponent (getConfigOptionfunction)buttonunit testsStepOptionsButtoninterfaceusagedocs with the new info about thebuttoncomponentThe common case for dynamic text and label button properties is when
Shepherdis used with an i18n (internationalization) solution and those fields need to be updated on change of the language settings. That has been already in place for the main text component but was missing for the buttons.