-
-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work in Microsoft Edge (EdgeHTML 18) #1023
Comments
@te1 I think Chromium Edge would be the only supported type of Edge. We only want to support the last couple versions. We dropped IE as well, and non-Chrome Edge I think is going to fall into the same category of not being supported. That being said, if adding |
The difference in JS bundle size is very minor. As I don't have Java installed the Closure Compiler part didn't work for me. CSS order seemed changed for me but the content was the same. Current
With Edge 18
+ function _extends() {
+ _extends = Object.assign || function (target) {
+ for (var i = 1; i < arguments.length; i++) {
+ var source = arguments[i];
+
+ for (var key in source) {
+ if (Object.prototype.hasOwnProperty.call(source, key)) {
+ target[key] = source[key];
+ }
+ }
+ }
+
+ return target;
+ };
+
+ return _extends.apply(this, arguments);
+ }
+
- popperOptions = { ...popperOptions,
+ popperOptions = _extends({}, popperOptions, {
modifiers: Array.from(new Set([...popperOptions.modifiers, ...centeredStylePopperModifier]))
- };
+ }); |
@te1 would you like to open a PR adding it? That bundle size difference seems fine to me. |
-Enables transpilation of object property spread -Required for (old) EdgeHTML 18 compatibility -Fixes #1023
Open https://shepherdjs.dev/ in Microsoft Edge and you can't access the demo because of a syntax error in the script.
SCRIPT1028: SCRIPT1028: Expected identifier, string or number
The problem is the
...popperOptions
object spread in the code below which is not supported in the (old) EdgeHTML 18 version.https://caniuse.com/#feat=mdn-javascript_operators_spread_spread_in_object_literals
Your browserlist specifies
last 2 Edge versions
which apparently doesn't include Edge 18 anymore (see Can I Use) but according to https://browserl.ist/?q=last+2+Edge+versions it still does. I'm not sure what to make of this.Transpilation should fix the problem, so including
Edge 18
in your browserlist should be enough. Alternatively maybe the documentation should explicitly state support for "Chromium Edge" only. The problem with that is that according to Can I Use EdgeHTML has a global usage of 2% and Chromium Edge is still at 0%.The text was updated successfully, but these errors were encountered: