Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer-dependency-analyser: prepend PHPStan's PharAutoloader to avoid false reports, drop nikic/php-parser #222

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

janedbal
Copy link
Member

@janedbal janedbal commented Mar 4, 2024

This should prevent errors like #220, now it (properly) detected the nikic/php-parser as unused:

image

Package nikic/php-parser is bundled inside PHPStan's phar and is loaded from there, so having it in require is useless.

@janedbal janedbal changed the title composer-dependency-analyser: prepend PHPStan's PharAutoloader to avoid false reports composer-dependency-analyser: prepend PHPStan's PharAutoloader to avoid false reports, drop nikic/php-parser Mar 5, 2024
@janedbal janedbal merged commit 9123cee into master Mar 5, 2024
12 checks passed
@janedbal janedbal deleted the cda-use-phpstan-autoloader branch March 5, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant