Fix UselessPrivatePropertyNullabilityRule false-positive for promoted…

… properties (#55)
shipmonk-rnd · Dec 2, 2022 · 01f9cd9 · 01f9cd9
1 parent 3a3f8b1
commit 01f9cd9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/Rule/UselessPrivatePropertyNullabilityRule.php b/src/Rule/UselessPrivatePropertyNullabilityRule.php
@@ -74,7 +74,7 @@ public function processNode(Node $node, Scope $scope): array
         $errors = [];
 
         foreach ($node->getProperties() as $property) {
-            $shouldBeChecked = $property->isPrivate() || $property->isReadOnly();
+            $shouldBeChecked = ($property->isPrivate() || $property->isReadOnly()) && !$property->isPromoted();
 
             if (!$shouldBeChecked) {
                 continue;

diff --git a/tests/Rule/data/UselessPrivatePropertyNullabilityRule/code.php b/tests/Rule/data/UselessPrivatePropertyNullabilityRule/code.php
@@ -26,7 +26,8 @@ public function __construct(
         int $isPrivate,
         int $isPrivateWithConditionalAssignment,
         int $isPrivateWithDefaultNull,
-        int $isPrivateWithDefaultNotNull
+        int $isPrivateWithDefaultNotNull,
+        private ?int $isPrivatePromoted
     ) {
         $this->isPublic = $isPublic;
         $this->isProtected = $isProtected;