Reflect code review feedback

lib/task_bunny/config.ex

@@ -189,7 +189,7 @@ defmodule TaskBunny.Config do
   @doc """
   Returns the list of failure backends.
 
-  It returns [TaskBunny.FailureBackend.Logger] by default.
+  It returns `TaskBunny.FailureBackend.Logger` by default.
   """
   @spec failure_backend :: [atom]
   def failure_backend do

lib/task_bunny/failure_backend.ex

@@ -1,6 +1,6 @@
 defmodule TaskBunny.FailureBackend do
   @moduledoc """
-  A behaviour module to implment the your own failure backend.
+  A behaviour module to implement the your own failure backend.
 
   Note the backend is called only for the errors caught during job processing.
   Any other errors won't be reported to the backend.
@@ -49,7 +49,5 @@ defmodule TaskBunny.FailureBackend do
   def report_job_error(job_error = %JobError{}) do
     Config.failure_backend()
     |> Enum.each(&(&1.report_job_error(job_error)))
-
-    :ok
   end
 end

lib/task_bunny/failure_backend/logger.ex

@@ -7,7 +7,7 @@ defmodule TaskBunny.FailureBackend.Logger do
   alias TaskBunny.JobError
 
   def report_job_error(error = %JobError{error_type: :exception}) do
-    message = """
+    """
     TaskBunny - #{error.job} failed for an exception.
 
     Exception:
@@ -18,55 +18,50 @@ defmodule TaskBunny.FailureBackend.Logger do
     Stacktrace:
     #{Exception.format_stacktrace(error.stacktrace)}
     """
-
-    do_report(message, error.reject)
+    |> do_report(error.reject)
   end
 
   def report_job_error(error = %JobError{error_type: :return_value}) do
-    message = """
+    """
     TaskBunny - #{error.job} failed for an invalid return value.
 
     Return value:
     #{my_inspect error.return_value}
 
     #{common_message error}
     """
-
-    do_report(message, error.reject)
+    |> do_report(error.reject)
   end
 
   def report_job_error(error = %JobError{error_type: :exit}) do
-    message = """
+    """
     TaskBunny - #{error.job} failed for EXIT signal.
 
     Reason:
     #{my_inspect error.reason}
 
     #{common_message error}
     """
-
-    do_report(message, error.reject)
+    |> do_report(error.reject)
   end
 
   def report_job_error(error = %JobError{error_type: :timeout}) do
-    message = """
+    """
     TaskBunny - #{error.job} failed for timeout.
 
     #{common_message error}
     """
-
-    do_report(message, error.reject)
+    |> do_report(error.reject)
   end
 
   def report_job_error(error) do
-    message = """
+    """
     TaskBunny - Failed with the unknown error type.
 
     Error dump:
     #{my_inspect error}
     """
-
-    do_report(message, true)
+    |> do_report(true)
   end
 
   defp do_report(message, rejected) do

lib/task_bunny/job_error.ex

@@ -22,7 +22,7 @@ defmodule TaskBunny.JobError do
   """
 
   @type t :: %__MODULE__{
-    job: atom,
+    job: atom | nil,
     payload: any,
     error_type: :exception | :return_value | :timeout | :exit | nil,
     exception: struct | nil,
@@ -34,7 +34,7 @@ defmodule TaskBunny.JobError do
     failed_count: integer,
     queue: String.t,
     concurrency: integer,
-    pid: pid,
+    pid: pid | nil,
     reject: boolean
   }
 
@@ -56,6 +56,7 @@ defmodule TaskBunny.JobError do
   ]
 
   @doc false
+  @spec handle_exception(atom, any, struct) :: t
   def handle_exception(job, payload, exception) do
     %__MODULE__{
       job: job,
@@ -67,6 +68,7 @@ defmodule TaskBunny.JobError do
   end
 
   @doc false
+  @spec handle_exit(atom, any, any) :: t
   def handle_exit(job, payload, reason) do
     %__MODULE__{
       job: job,
@@ -77,6 +79,7 @@ defmodule TaskBunny.JobError do
   end
 
   @doc false
+  @spec handle_return_value(atom, any, any) :: t
   def handle_return_value(job, payload, return_value) do
     %__MODULE__{
       job: job,
@@ -87,6 +90,7 @@ defmodule TaskBunny.JobError do
   end
 
   @doc false
+  @spec handle_timeout(atom, any) :: t
   def handle_timeout(job, payload) do
     %__MODULE__{
       job: job,