Fix issue 136: Download music by "Search Music" error #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shiningw Please release this? |
Happyfeet01
reviewed
Aug 26, 2024
There was a problem hiding this comment.
i must change the URL to hayqbhgr.slider.kz
at line 40 and 11 to https://hayqbhgr.slider.kz then it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the bug
Music can download but size is 0
To Reproduce
Steps to reproduce the behavior:
Go to 'Search Torrents'
Change to 'MUSIC' search
Click 'Search',then download some music.
See error
Expected behavior
Music can be download and can play normally
Desktop (please complete the following information):
Any device
Smartphone (please complete the following information):
Any device
How to fix
Goto file: /apps/ncdownloader/lib/Search/Sites/sliderkz.php
Fix :
protected function getDownloadUrl(array $item): string
{
extract($item);
return sprintf("https://slider.kz/%s/%s/%s/%s.mp3?extra=null",$id,$duration, $durl, urlencode($tit_art));
}